Index: trunk/extensions/Configure/Configure.page.php |
— | — | @@ -699,7 +699,7 @@ |
700 | 700 | } |
701 | 701 | |
702 | 702 | if ( array_key_exists( $name, $settings ) ) { |
703 | | - $settings[$name] = $this->cleanupSetting( $name, $settings[$name] ); |
| 703 | + $settings[$name] = $this->cleanupSetting( $name, $settings[$name], $type ); |
704 | 704 | if ( $settings[$name] === null ) |
705 | 705 | unset( $settings[$name] ); |
706 | 706 | } |
— | — | @@ -715,10 +715,10 @@ |
716 | 716 | * @param $val Mixed: setting value |
717 | 717 | * @return Mixed |
718 | 718 | */ |
719 | | - protected function cleanupSetting( $name, $val ) { |
| 719 | + protected function cleanupSetting( $name, $val, $type ) { |
720 | 720 | global $wgConf; |
721 | 721 | |
722 | | - if (!empty($val) || $val) { |
| 722 | + if ( !empty( $val ) || $val || $type == 'bool' ) { |
723 | 723 | return $val; |
724 | 724 | } |
725 | 725 | |
— | — | @@ -727,7 +727,7 @@ |
728 | 728 | $list = $this->mConfSettings->getEmptyValues(); |
729 | 729 | |
730 | 730 | static $defaults = null; |
731 | | - if ($defaults === null) |
| 731 | + if ( $defaults === null ) |
732 | 732 | $defaults = $wgConf->getDefaultsForWiki( $this->mWiki ); |
733 | 733 | |
734 | 734 | if ( array_key_exists( $name, $list ) ) { |
Index: trunk/extensions/Configure/CHANGELOG |
— | — | @@ -1,6 +1,10 @@ |
2 | 2 | This file lists changes on this extension. |
3 | 3 | Localisation updates are done on betawiki and aren't listed here. |
4 | 4 | |
| 5 | +0.12.2 - 9 February 2009 |
| 6 | + (bug 17403) Boolean settings set to false when the default value is true is |
| 7 | + now properly recognised. |
| 8 | + |
5 | 9 | 0.12.1 - 7 February 2009 |
6 | 10 | * Updated AbuseFilter and FlaggedRevs extensions |
7 | 11 | * Removed obsolete extensions DeletedContributions, LinkSearch and Newuserlog |
Index: trunk/extensions/Configure/Configure.php |
— | — | @@ -17,7 +17,7 @@ |
18 | 18 | 'url' => 'http://www.mediawiki.org/wiki/Extension:Configure', |
19 | 19 | 'description' => 'Allow authorised users to configure the wiki via a web-based interface', |
20 | 20 | 'descriptionmsg' => 'configure-desc', |
21 | | - 'version' => '0.12.1', |
| 21 | + 'version' => '0.12.2', |
22 | 22 | ); |
23 | 23 | |
24 | 24 | # Configuration part |