r46918 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r46917‎ | r46918 | r46919 >
Date:14:43, 6 February 2009
Author:mkroetzsch
Status:deferred
Tags:
Comment:
undefined variable in some cases, fixed
Modified paths:
  • /trunk/extensions/SemanticMediaWiki/maintenance/SMW_setup.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticMediaWiki/maintenance/SMW_setup.php
@@ -13,7 +13,7 @@
1414 * Usage:
1515 * php SMW_refreshData.php [options...]
1616 *
17 - * -b <backend> Execute the operation for the storage backend of the given name
 17+ * -b <backend> Execute the operation for the storage backend of the given name
1818 * -user <dbuser> Database user account to use for chaning DB layout
1919 * -password <dbpassword> Password for user account
2020 * NOTE: specifying user credentials in a command line call will usually store them
@@ -23,7 +23,7 @@
2424 *
2525 * --delete Delete all SMW data, uninstall the selected storage backend. This is useful
2626 * when moving to a new storage engine, and in the rare case of unsinstalling
27 - * SMW. Deleted data can be recreated using this script (setup) and
 27+ * SMW. Deleted data can be recreated using this script (setup) and
2828 * SMW_refreshData.php but this may take some time.
2929 * @author Markus Krötzsch
3030 * @file
@@ -62,11 +62,10 @@
6363 $wgDBpassword = $options['password'];
6464 }
6565
 66+$alternativestore = false;
6667 if ( array_key_exists( 'b', $options ) ) {
6768 if ($smwgDefaultStore != $options['b']) {
6869 $alternativestore = true;
69 - } else {
70 - $alternativestore = false;
7170 }
7271 $smwgDefaultStore = $options['b'];
7372 print "\nSelected storage " . $smwgDefaultStore . " for update!\n\n";
@@ -74,7 +73,7 @@
7574
7675
7776 global $smwgIP;
78 -if (! isset($smwgIP))
 77+if (! isset($smwgIP))
7978 $smwgIP = dirname(__FILE__) . '/..';
8079
8180 require_once($smwgIP . '/includes/SMW_GlobalFunctions.php');

Status & tagging log