r46914 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r46913‎ | r46914 | r46915 >
Date:13:38, 6 February 2009
Author:malafaya
Status:deferred
Tags:
Comment:
Adapting for trunk; also works on branch:
* ApiFormatBase public methods must be public in derived classes too
Modified paths:
  • /trunk/extensions/Wikidata/includes/api/ApiWikiData.php (modified) (history)
  • /trunk/extensions/Wikidata/includes/api/ApiWikiDataFormatXml.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Wikidata/includes/api/ApiWikiDataFormatXml.php
@@ -204,7 +204,7 @@
205205
206206 }
207207
208 - protected function getDescription() {
 208+ public function getDescription() {
209209 return 'Output WikiData defined meaning in XML format' . parent :: getDescription();
210210 }
211211
Index: trunk/extensions/Wikidata/includes/api/ApiWikiData.php
@@ -319,7 +319,7 @@
320320 return $this->printer;
321321 }
322322
323 - protected function getAllowedParams() {
 323+ public function getAllowedParams() {
324324 return array (
325325 'type' => array (
326326 ApiBase :: PARAM_DFLT => 'expression',
@@ -371,7 +371,7 @@
372372 );
373373 }
374374
375 - protected function getParamDescription() {
 375+ public function getParamDescription() {
376376 return array (
377377 'type' => array (
378378 'Query type.',
@@ -417,7 +417,7 @@
418418 );
419419 }
420420
421 - protected function getDescription() {
 421+ public function getDescription() {
422422 return array (
423423 'This module provides an API to WikiData.'
424424 );

Status & tagging log