r46874 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r46873‎ | r46874 | r46875 >
Date:19:55, 5 February 2009
Author:nikerabbit
Status:deferred (Comments)
Tags:
Comment:
* STFU E_WARN, please review for correcteness
Modified paths:
  • /trunk/phase3/includes/PrefixSearch.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/PrefixSearch.php
@@ -135,7 +135,7 @@
136136
137137 // Reformat useful data for future printing by JSON engine
138138 $srchres = array ();
139 - foreach ($data['query']['allpages'] as & $pageinfo) {
 139+ foreach ((array)$data['query']['allpages'] as $pageinfo) {
140140 // Note: this data will no be printable by the xml engine
141141 // because it does not support lists of unnamed items
142142 $srchres[] = $pageinfo['title'];

Comments

#Comment by Catrope (talk | contribs)   10:54, 6 February 2009

Looks correct to me

Status & tagging log