r46843 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r46842‎ | r46843 | r46844 >
Date:11:59, 5 February 2009
Author:ialex
Status:deferred
Tags:
Comment:
(bug 17366) fix for r46840: Xml::encodeJsVar() already escapes and quotes $conf->DBtype, no need to do it twice
Modified paths:
  • /trunk/phase3/config/index.php (modified) (history)

Diff [purge]

Index: trunk/phase3/config/index.php
@@ -1544,7 +1544,7 @@
15451545 </div>
15461546 </form>
15471547 <script type="text/javascript">
1548 -window.onload = toggleDBarea('<?php echo htmlspecialchars( Xml::encodeJsVar( $conf->DBtype ) ); ?>',
 1548+window.onload = toggleDBarea( <?php echo Xml::encodeJsVar( $conf->DBtype ); ?>,
15491549 <?php
15501550 ## If they passed in a root user name, don't populate it on page load
15511551 echo strlen(importPost('RootUser', '')) ? 0 : 1;

Follow-up revisions

RevisionCommit summaryAuthorDate
r46891Backported r46840, r46843, r46889tstarling04:54, 6 February 2009
r46892Backported r46840, r46843, r46889 (installer XSS fixes)tstarling05:05, 6 February 2009
r46898Backported r46840, r46843, r46889 (installer XSS fixes)tstarling05:47, 6 February 2009
r46899Backported r46840, r46843, r46889 (installer XSS fixes)tstarling06:29, 6 February 2009

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r46840* Fixed a whole lot of XSS vulnerabilities in the installer. All require a li...tstarling08:56, 5 February 2009

Status & tagging log