r46827 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r46826‎ | r46827 | r46828 >
Date:23:39, 4 February 2009
Author:demon
Status:deferred
Tags:
Comment:
More Http::get() usage instead of file_get_contents.
Modified paths:
  • /trunk/extensions/ExternalData/ED_ParserFunctions.php (modified) (history)

Diff [purge]

Index: trunk/extensions/ExternalData/ED_ParserFunctions.php
@@ -143,7 +143,7 @@
144144 }
145145
146146 if( !isset( $edgCacheTable ) || is_null( $edgCacheTable ) )
147 - return @file_get_contents( $url );
 147+ return Http::get( $url );
148148
149149 // check the cache (only the first 254 chars of the url)
150150 $res = $dbr->select( $edgCacheTable, '*', array( 'url' => substr($url,0,254) ), 'EDParserFunctions::doRequest' );

Status & tagging log