r46814 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r46813‎ | r46814 | r46815 >
Date:19:59, 4 February 2009
Author:werdna
Status:deferred
Tags:
Comment:
Variable naming conflict.
Modified paths:
  • /trunk/extensions/AbuseFilter/SpecialAbuseLog.php (modified) (history)

Diff [purge]

Index: trunk/extensions/AbuseFilter/SpecialAbuseLog.php
@@ -185,9 +185,9 @@
186186 $parsed_comments = $wgOut->parseInline( $row->af_public_comments );
187187
188188 if ($this->canSeeDetails()) {
189 - $title = $this->getTitle( "examine/log/".$row->afl_id );
 189+ $examineTitle = $this->getTitle( "examine/log/".$row->afl_id );
190190 $detailsLink = $sk->makeKnownLinkObj( $this->getTitle( ), wfMsg( 'abusefilter-log-detailslink' ), 'details='.$row->afl_id );
191 - $examineLink = $sk->link( $title, wfMsgExt( 'abusefilter-changeslist-examine', 'parseinline' ), array() );
 191+ $examineLink = $sk->link( $examineTitle, wfMsgExt( 'abusefilter-changeslist-examine', 'parseinline' ), array() );
192192
193193 $description = wfMsgExt( 'abusefilter-log-detailedentry', array( 'parseinline', 'replaceafter' ), array( $timestamp, $user, $row->afl_filter, $row->afl_action, $sk->makeKnownLinkObj( $title ), $actions_taken, $parsed_comments, $detailsLink, $examineLink ) );
194194 } else {

Status & tagging log