r46479 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r46478‎ | r46479 | r46480 >
Date:20:03, 28 January 2009
Author:aaron
Status:resolved (Comments)
Tags:
Comment:
(bug 17193) Carry $this->mReUpload over with hidden field for better consistency after upload errors
Modified paths:
  • /trunk/phase3/includes/specials/SpecialUpload.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialUpload.php
——@@ -1250,6 +1250,7 @@
12511251 </tr>" .
12521252 Xml::closeElement( 'table' ) .
12531253 Xml::hidden( 'wpDestFileWarningAck', '', array( 'id' => 'wpDestFileWarningAck' ) ) .
 1254+ xml::hidden( 'wpReUpload', $this->mReUpload ) .
12541255 Xml::closeElement( 'fieldset' ) .
12551256 Xml::closeElement( 'form' )
12561257 );

Comments

#Comment by Brion VIBBER (talk | contribs)   20:09, 28 January 2009

This will be interpreted as every form submission being a reupload:

$this->mReUpload = $request->getCheck( 'wpReUpload' );

Further this seems to fail absolutely since it's attempting to cancel the upload when you submit a reupload or something.

Status & tagging log