r46459 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r46458‎ | r46459 | r46460 >
Date:19:05, 28 January 2009
Author:dale
Status:deferred
Tags:
Comment:
* license stub for remote media search
* cancel working
Modified paths:
  • /trunk/extensions/MetavidWiki/skins/mv_embed/libAddMedia/mv_remote_media_search.js (modified) (history)
  • /trunk/extensions/MetavidWiki/skins/mv_embed/libSequencer/mv_clipedit.js (modified) (history)

Diff [purge]

Index: trunk/extensions/MetavidWiki/skins/mv_embed/libAddMedia/mv_remote_media_search.js
@@ -39,6 +39,11 @@
4040
4141 'enable_uploads':false // if we want to enable an uploads tab:
4242 }
 43+/* licence_templateObj lists all the licence templates and their coresponding icon and short text description */
 44+var licence_templateObj = {
 45+
 46+}
 47+
4348 var remoteSearchDriver = function(initObj){
4449 return this.init( initObj );
4550 }
@@ -72,17 +77,18 @@
7378 //domain insert: two modes: simple config or domain list:
7479 @local : if the content provider assets need to be imported or not.
7580 @local_domains : sets of domains for which the content is local
 81+ //@@todo should query wgForeignFileRepos setting maybe interwikimap from the api
7682 */
7783 'this_wiki':{
78 - 'enabled':0,
79 - 'checked':0,
80 - 'd' :0,
81 - 'title' :'This Wiki',
82 - 'desc' : '(should be updated with the proper text) maybe import from some config value',
 84+ 'enabled': 0,
 85+ 'checked': 0,
 86+ 'd' : 0,
 87+ 'title' : 'This Wiki',
 88+ 'desc' : '(should be updated with the proper text) maybe import from some config value',
8389 'api_url': wgServer + wgScriptPath + '/api.php',
84 - 'lib' :'mediaWiki',
85 - 'local' :true,
86 - 'tab_img':false
 90+ 'lib' : 'mediaWiki',
 91+ 'local' : true,
 92+ 'tab_img': false
8793 },
8894 'wiki_commons':{
8995 'enabled':1,
@@ -1300,7 +1306,11 @@
13011307 if(page.revisions[0]['*'].indexOf('#REDIRECT')===0){
13021308 //skip page is redirect
13031309 continue;
1304 - }
 1310+ }
 1311+ //skip if its an empy or missing imageinfo:
 1312+ if(!page.imageinfo)
 1313+ continue;
 1314+
13051315 this.resultsObj[page_id]={
13061316 'titleKey' : page.title,
13071317 'link' :page.imageinfo[0].descriptionurl,
Index: trunk/extensions/MetavidWiki/skins/mv_embed/libSequencer/mv_clipedit.js
@@ -324,7 +324,7 @@
325325 '<a href="#" class="mv_cancel_img_edit" title="' + getMsg('mv_cancel_image_insert')+'">' + getMsg('mv_cancel_image_insert') + '</a> ');
326326 //$j('#'+this.control_ct).append( this.getInsertDesc() + this.getInsertAction() );
327327
328 - //this.applyInsertControlBindings();
 328+ this.applyInsertControlBindings();
329329 },
330330 setInOutBindings:function(){
331331 //setup bindings for adjust / preview:

Status & tagging log