r46273 MediaWiki - Code Review archive

Repository:	MediaWiki
Revision:	< r46272‎ \| r46273 \| r46274 >
Date:	18:52, 26 January 2009
Author:	werdna
Status:	deferred
Tags:
Comment:	If no groups are being removed, then don't add a LogPage entry for the 'degroup' action!
Modified paths:	/trunk/extensions/AbuseFilter/AbuseFilter.class.php (modified) (history)

Diff [purge]

Index: trunk/extensions/AbuseFilter/AbuseFilter.class.php
—	—	@@ -390,6 +390,11 @@
391	391
392	392	$display .= wfMsgNoTrans( 'abusefilter-degrouped', $rule_desc ) ."<br />\n";
393	393
	394	+ // Don't log it if there aren't any groups being removed!
	395	+ if (!count($groups)) {
	396	+ break;
	397	+ }
	398	+
394	399	// Log it.
395	400	$log = new LogPage( 'rights' );
396	401

01:37, 27 January 2009 Brion VIBBER (talk | contribs) changed the status of r46273 [removed: new added: deferred]