r46234 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r46233‎ | r46234 | r46235 >
Date:21:09, 25 January 2009
Author:raymond
Status:ok
Tags:
Comment:
Add a space between dropdown menu and submit button
Use Xml::functions
Modified paths:
  • /trunk/extensions/ExtensionDistributor/ExtensionDistributor_body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/ExtensionDistributor/ExtensionDistributor_body.php
@@ -125,10 +125,11 @@
126126 $wgOut->addHTML( Xml::element( 'option', array( 'value' => $extension ), $extension ) . "\n" );
127127 }
128128
129 - $wgOut->addHTML( "</select>" .
130 - Xml::element( 'input', array( 'type' => 'submit', 'name' => 'extdist_submit',
131 - 'value' => wfMsg( 'extdist-submit-extension' ) ) ) .
132 - "</form>\n" );
 129+ $wgOut->addHTML(
 130+ Xml::closeElement( 'select' ) . ' ' .
 131+ Xml::submitButton( wfMsg( 'extdist-submit-extension' ), array( 'name' => 'extdist_submit' ) ) .
 132+ Xml::closeElement( 'form' ) . "\n"
 133+ );
133134 }
134135
135136 function showVersionSelector( $extensionName ) {
@@ -167,10 +168,10 @@
168169 $wgOut->addHTML( Xml::element( 'option',
169170 array( 'value' => $branchPath ), $branchName ) . "\n" );
170171 }
171 - $wgOut->addHTML( "</select>" .
172 - Xml::element( 'input', array( 'type' => 'submit', 'name' => 'extdist_submit',
173 - 'value' => wfMsg( 'extdist-submit-version' ) ) ) .
174 - "</form>\n"
 172+ $wgOut->addHTML(
 173+ Xml::closeElement( 'select' ) . ' ' .
 174+ Xml::submitButton( wfMsg( 'extdist-submit-version' ), array( 'name' => 'extdist_submit' ) ) .
 175+ Xml::closeElement( 'form' ) . "\n"
175176 );
176177 }
177178

Status & tagging log