r46229 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r46228‎ | r46229 | r46230 >
Date:20:54, 25 January 2009
Author:aaron
Status:ok (Comments)
Tags:
Comment:
Remove redundant 'userpage' promote param
Modified paths:
  • /trunk/extensions/FlaggedRevs/FlaggedRevs.hooks.php (modified) (history)
  • /trunk/extensions/FlaggedRevs/FlaggedRevs.php (modified) (history)

Diff [purge]

Index: trunk/extensions/FlaggedRevs/FlaggedRevs.php
@@ -209,8 +209,7 @@
210210 'uniqueContentPages' => 12, # $wgContentNamespaces unique pages edited
211211 'editComments' => 50, # how many edit comments used?
212212 'email' => false, # user must be emailconfirmed?
213 - 'userpage' => false, # user must have a userpage?
214 - 'userpageBytes' => 100, # if userpage is needed, what is the min size?
 213+ 'userpageBytes' => 0, # userpage is needed? with what min size?
215214 'uniqueIPAddress' => false, # If $wgPutIPinRC is true, users sharing IPs won't be promoted
216215 'neverBlocked' => true, # Can users that were blocked be promoted?
217216 'maxRevertedEdits' => 5, # Max edits the user could have had rolled back?
Index: trunk/extensions/FlaggedRevs/FlaggedRevs.hooks.php
@@ -931,7 +931,7 @@
932932 }
933933 }
934934 # See if the page actually has sufficient content...
935 - if( $wgFlaggedRevsAutopromote['userpage'] ) {
 935+ if( $wgFlaggedRevsAutopromote['userpageBytes'] > 0 ) {
936936 if( !$user->getUserPage()->exists() ) {
937937 wfProfileOut( __METHOD__ );
938938 return true;

Comments

#Comment by Gurch (talk | contribs)   23:21, 25 January 2009

Was this actually redundant? Seems to me that having a blank userpage will now count as not having one. (Mind you, I'm at a loss as to why this option even exists)

#Comment by Aaron Schulz (talk | contribs)   23:47, 25 January 2009

I already considered blank users pages, which would pretty much defeat the purpose of the check anyway. Either it needs content or not.

At any rate, this is off be default since WMF projects don't care much for user pages.

Status & tagging log