r46194 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r46193‎ | r46194 | r46195 >
Date:11:56, 25 January 2009
Author:siebrand
Status:deferred
Tags:
Comment:
Remove 'amazonplus-status-sep' and use 'comma-separator' from core
Modified paths:
  • /trunk/extensions/AmazonPlus/AmazonPlus.i18n.php (modified) (history)
  • /trunk/extensions/AmazonPlus/AmazonPlus.php (modified) (history)
  • /trunk/extensions/Translate/groups/mediawiki-defines.txt (modified) (history)

Diff [purge]

Index: trunk/extensions/AmazonPlus/AmazonPlus.php
@@ -437,7 +437,7 @@
438438 foreach ( $extra as $val ) {
439439 $msg = wfMsg( $val );
440440 if ( $msg == '' ) continue;
441 - if ( $i++ != 0 ) $params .= wfMsg( 'amazonplus-status-sep' );
 441+ if ( $i++ != 0 ) $params .= wfMsg( 'comma-separator' );
442442 $params .= $msg;
443443 }
444444 if ( $params ) $app = ' ' . wfMsg( 'amazonplus-status', $params );
Index: trunk/extensions/AmazonPlus/AmazonPlus.i18n.php
@@ -25,7 +25,6 @@
2626 'amazonplus-amazon' => 'amazon price',
2727 'amazonplus-new' => 'new',
2828 'amazonplus-status' => '($1)',
29 - 'amazonplus-status-sep' => ', ',
3029 'amazonplus-none' => 'No copies of this item are up for sale.',
3130 'amazonplus-currency' => '$3$1 $2$4',
3231 'amazonplus-cp-none' => 'None',
@@ -54,7 +53,6 @@
5554 'amazonplus-japanese' => 'Name of the Japanese language, or an empty string if translating to Japanese.',
5655 'amazonplus-english' => 'Name of the English language, or an empty string if translating to English.',
5756 'amazonplus-status' => ';$1:A combination of status messages seperated with [[MediaWiki:Amazonplus-status-sep/en|amazonplus-status-sep]]',
58 - 'amazonplus-status-sep' => 'Seperator used in [[MediaWiki:Amazonplus-status/en|amazonplus-status]] to divide the listing of terms',
5957 'amazonplus-currency' => ';$1:Formatted price without symbol (e.g. 16.41)
6058 ;$2:Currency code (e.g. USD)
6159 ;$3:Currency symbol (e.g. $)
@@ -100,7 +98,6 @@
10199 'amazonplus-japanese' => 'يابانية',
102100 'amazonplus-amazon' => 'سعر أمازون',
103101 'amazonplus-new' => 'جديد',
104 - 'amazonplus-status-sep' => ',',
105102 'amazonplus-none' => 'مافيش نسخ من الصنف دا معروضه للبيع',
106103 'amazonplus-cp-none' => 'لا شيء',
107104 'amazonplus-more' => 'أكثر',
@@ -245,7 +242,6 @@
246243 'amazonplus-amazon' => 'amazon prezioa',
247244 'amazonplus-new' => 'berria',
248245 'amazonplus-status' => '($1)',
249 - 'amazonplus-status-sep' => ',',
250246 'amazonplus-none' => 'Ez dago artikulu honen kopiarik salgai.',
251247 'amazonplus-currency' => '$1$3 $4$2',
252248 'amazonplus-cp-none' => 'Bat ere ez',
@@ -474,7 +470,6 @@
475471 'amazonplus-amazon' => 'dä Priiß bei <i lang="en">Amazon</i>',
476472 'amazonplus-new' => 'neu',
477473 'amazonplus-status' => '($1)',
478 - 'amazonplus-status-sep' => ',',
479474 'amazonplus-none' => 'Et es jraad kei Stöck dovun em Aanjebott.',
480475 'amazonplus-currency' => '$3$1 $2$4',
481476 'amazonplus-cp-none' => 'Nix',
@@ -717,7 +712,6 @@
718713 'amazonplus-amazon' => 'cena na Amazon',
719714 'amazonplus-new' => 'nové',
720715 'amazonplus-status' => '($1)',
721 - 'amazonplus-status-sep' => ',',
722716 'amazonplus-none' => 'Nepredávajú sa žiadne kópie tejto položky.',
723717 'amazonplus-currency' => '$3$1 $2$4',
724718 'amazonplus-cp-none' => 'Žiadne',
@@ -798,7 +792,6 @@
799793 'amazonplus-amazon' => 'amazon fiyatı',
800794 'amazonplus-new' => 'yeni',
801795 'amazonplus-status' => '($1)',
802 - 'amazonplus-status-sep' => ',',
803796 'amazonplus-none' => 'Bu ürünün hiçbir kopyası satılık değil.',
804797 'amazonplus-currency' => '$1$3 $2$4',
805798 'amazonplus-cp-none' => 'Hiç',
Index: trunk/extensions/Translate/groups/mediawiki-defines.txt
@@ -17,7 +17,7 @@
1818 descmsg = ajax-se-desc
1919
2020 Amazon Plus
21 -optional = amazonplus-status, amazonplus-status-sep, amazonplus-currency
 21+optional = amazonplus-status, amazonplus-currency
2222 optional = amazonplus-cp-usd, amazonplus-cp-cad, amazonplus-cp-gbp, amazonplus-cp-eur
2323 optional = amazonplus-cp-jpy
2424 ignored = amazonplus-english

Status & tagging log