r46189 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r46188‎ | r46189 | r46190 >
Date:06:52, 25 January 2009
Author:aaron
Status:ok
Tags:
Comment:
Removed 'totalReviewedEdits' param, not needed due to 'totalCheckedEdits' param
Modified paths:
  • /trunk/extensions/FlaggedRevs/FlaggedRevs.hooks.php (modified) (history)
  • /trunk/extensions/FlaggedRevs/FlaggedRevs.php (modified) (history)
  • /trunk/extensions/FlaggedRevs/specialpages/RevisionReview_body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/FlaggedRevs/FlaggedRevs.php
@@ -203,10 +203,9 @@
204204 'spacing' => 3, # spacing of edit intervals
205205 'benchmarks' => 15, # how many edit intervals are needed?
206206 'recentContentEdits' => 5, # $wgContentNamespaces edits in recent changes
207 - // Either totalContentEdits reqs OR totalCheckedEdits/totalReviewedEdits requirements needed
 207+ // Either totalContentEdits reqs OR totalCheckedEdits requirements needed
208208 'totalContentEdits' => 300, # $wgContentNamespaces edits OR...
209 - 'totalCheckedEdits' => 0, # ...Edits before the stable version of pages AND...
210 - 'totalReviewedEdits' => 0, # ...Edits that were specifically sighted
 209+ 'totalCheckedEdits' => 0, # ...Edits before the stable version of pages
211210 'uniqueContentPages' => 12, # $wgContentNamespaces unique pages edited
212211 'editComments' => 50, # how many edit comments used?
213212 'email' => false, # user must be emailconfirmed?
Index: trunk/extensions/FlaggedRevs/specialpages/RevisionReview_body.php
@@ -656,16 +656,6 @@
657657 }
658658 # Update link tracking. This will trigger our hook to add stable links too...
659659 $u->doUpdate();
660 -
661 - # Update user stats if this rev was not flagged
662 - if( !$oldfrev && $rev->getRawUser() ) {
663 - global $wgFlaggedRevsAutopromote;
664 - $p = FlaggedRevs::getUserParams( $rev->getRawUser() );
665 - $p['reviewedEdits'] = isset($p['reviewedEdits']) ? $p['reviewedEdits'] : 0;
666 - $p['reviewedEdits']++;
667 - if( $wgFlaggedRevsAutopromote['totalReviewedEdits'] >= $p['reviewedEdits'] )
668 - FlaggedRevs::saveUserParams( $rev->getRawUser(), $p );
669 - }
670660
671661 $dbw->commit();
672662 # Purge cache/squids for this page and any page that uses it
Index: trunk/extensions/FlaggedRevs/FlaggedRevs.hooks.php
@@ -865,11 +865,6 @@
866866 # Check if user edited enough content pages
867867 $totalCheckedEditsNeeded = false;
868868 if( $wgFlaggedRevsAutopromote['totalContentEdits'] > $p['totalContentEdits'] ) {
869 - # Check if the user has enough sighted edits
870 - if( $wgFlaggedRevsAutopromote['totalReviewedEdits'] > $p['reviewedEdits'] ) {
871 - wfProfileOut( __METHOD__ );
872 - return true;
873 - }
874869 $totalCheckedEditsNeeded = true;
875870 }
876871 # Check if user edited enough unique pages

Status & tagging log