r46184 MediaWiki - Code Review archive
Repository:
MediaWiki
Revision:
<
r46183
|
r46184
|
r46185
>
Date:
05:25, 25 January 2009
Author:
werdna
Status:
deferred
Tags:
Comment:
Fix weird method of checking if any MulRel operations worked.
Modified paths:
/trunk/extensions/AbuseFilter/AbuseFilter.parser.php
(modified) (
history
)
Diff
[
purge
]
Index: trunk/extensions/AbuseFilter/AbuseFilter.parser.php
—
—
@@ -219,15 +219,15 @@
220
220
$a = $a->toInt();
221
221
$b = $b->toInt();
222
222
}
223
-
223
+
224
+ $data = null;
224
225
if( $op == '*' )
225
226
$data = $a * $b;
226
- if( $op == '/' )
227
+ elseif( $op == '/' )
227
228
$data = $a / $b;
228
- if( $op == '%' )
229
+ elseif( $op == '%' )
229
230
$data = $a % $b;
230
-
231
- if (!$data)
231
+ else
232
232
throw new AFPException( "Invalid multiplication-related operation: {$op}" );
233
233
234
234
if ($type == self::DInt)
Status & tagging log
23:42, 26 January 2009
Brion VIBBER
(
talk
|
contribs
)
changed the
status
of r46184
[
removed:
new
added:
deferred]