r46135 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r46134‎ | r46135 | r46136 >
Date:13:03, 24 January 2009
Author:catrope
Status:resolved (Comments)
Tags:
Comment:
Backport r46134 (killed filesort in ApiQueryBacklinks)
Modified paths:
  • /branches/REL1_14/phase3/includes/api/ApiQueryBacklinks.php (modified) (history)

Diff [purge]

Index: branches/REL1_14/phase3/includes/api/ApiQueryBacklinks.php
——@@ -137,13 +137,12 @@
138138 $this->addFields($this->bl_title);
139139 if($this->hasNS)
140140 $this->addFields($this->bl_ns);
141 - $titleWhere = '';
 141+ $titleWhere = array();
142142 foreach($this->redirTitles as $t)
143 - $titleWhere .= ($titleWhere != '' ? " OR " : '') .
144 - "({$this->bl_title} = ".$db->addQuotes($t->getDBKey()).
 143+ $titleWhere[] = "({$this->bl_title} = ".$db->addQuotes($t->getDBKey()).
145144 ($this->hasNS ? " AND {$this->bl_ns} = '{$t->getNamespace()}'" : "") .
146145 ")";
147 - $this->addWhere($titleWhere);
 146+ $this->addWhere($db->makeList($titleWhere, LIST_OR));
148147 $this->addWhereFld('page_namespace', $this->params['namespace']);
149148 if(!is_null($this->redirID))
150149 {

Follow-up revisions

RevisionCommit summaryAuthorDate
r47376RELEASE-NOTES for r46134, backported in r46135.werdna19:30, 17 February 2009

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r46134API: (bug 16483) Kill filesort in ApiQueryBacklinks caused by missing parenth...catrope13:00, 24 January 2009

Comments

#Comment by Brion VIBBER (talk | contribs)   23:00, 26 January 2009

Release notes not updated

#Comment by Catrope (talk | contribs)   12:50, 27 January 2009

I was under the impression that internal stuff like this (performance tweaks, refactorings, rewrites) that don't change user-observed behavior didn't belong in RELEASE-NOTES?

#Comment by Brion VIBBER (talk | contribs)   23:14, 27 January 2009

If it was important enough to file a bug, it's important enough to put in the release notes.

#Comment by Werdna (talk | contribs)   19:30, 17 February 2009

RELEASE-NOTES added in r47376.

Status & tagging log