r45999 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r45998‎ | r45999 | r46000 >
Date:02:11, 22 January 2009
Author:dale
Status:deferred
Tags:
Comment:
fixed date loading text value bug
Modified paths:
  • /trunk/extensions/MetavidWiki/skins/mv_common.js (modified) (history)
  • /trunk/extensions/MetavidWiki/skins/mv_embed/mv_embed.js (modified) (history)
  • /trunk/extensions/MetavidWiki/skins/mv_search.js (modified) (history)
  • /trunk/extensions/MetavidWiki/skins/mv_stream.js (modified) (history)

Diff [purge]

Index: trunk/extensions/MetavidWiki/skins/mv_search.js
@@ -268,7 +268,7 @@
269269 $j('#mv_close_clip_'+mvd_id).fadeIn('fast');
270270 });
271271
272 - $j('#mvr_'+mvd_id).css('display', 'block').html(global_loading_txt);
 272+ $j('#mvr_'+mvd_id).css('display', 'block').html( getMsg('loading_txt') );
273273 //grab search terms:
274274 var terms='';
275275 $j('.mv_hl_text').each(function(){
Index: trunk/extensions/MetavidWiki/skins/mv_common.js
@@ -1,5 +1,4 @@
2 -/*@@TODO should be set by mediaWiki so it uses wfMsg */
3 -var global_loading_txt = 'loading<blink>...</blink>';
 2+/*@@TODO should be set by mediaWiki so it uses wfMsg */
43
54 /*
65 * adds adjustment hooks
Index: trunk/extensions/MetavidWiki/skins/mv_stream.js
@@ -492,7 +492,7 @@
493493 /*function mv_adjust_disp(titleKey, mvd_id){
494494 sajax_request_type='GET';
495495 sajax_do_call( "mv_adjust_disp", [titleKey, mvd_id], f );
496 - $j('#mv_fcontent_'+mvd_id).html(global_loading_txt);
 496+ $j('#mv_fcontent_'+mvd_id).html( getMsg('loading_txt') );
497497 //hanndle the response:
498498 function f( request ) {
499499 result= request.responseText;
Index: trunk/extensions/MetavidWiki/skins/mv_embed/mv_embed.js
@@ -620,7 +620,7 @@
621621 start:function(e, ui){
622622 var id = (embedObj.pc!=null)?embedObj.pc.pp.id:embedObj.id;
623623 embedObj.userSlide=true;
624 - js_log("started dragging set userSlide"+embedObj.userSlide)
 624+ js_log("started dragging set userSlide" + embedObj.userSlide)
625625 var options = ui.options;
626626 //remove "play button"
627627 $j('#big_play_link_'+id).fadeOut('fast');
@@ -634,7 +634,7 @@
635635 /
636636 ($j('#mv_seeker_'+embedObj.id).width()-14));
637637
638 - embedObj.jump_time = seconds2ntp(parseInt(embedObj.getDuration()*perc)+ embedObj.start_time_sec);
 638+ embedObj.jump_time = seconds2ntp( parseInt( embedObj.getDuration() * perc ) + embedObj.start_time_sec);
639639 //js_log('perc:' + perc + ' * ' + embedObj.getDuration() + ' jt:'+ this.jump_time);
640640 embedObj.setStatus( getMsg('seek_to')+' '+embedObj.jump_time );
641641 //update the thumbnail / frame

Status & tagging log