r45941 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r45940‎ | r45941 | r45942 >
Date:23:04, 20 January 2009
Author:aaron
Status:ok
Tags:
Comment:
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/Skin.php (modified) (history)
  • /trunk/phase3/skins/CologneBlue.php (modified) (history)
  • /trunk/phase3/skins/Modern.php (modified) (history)
  • /trunk/phase3/skins/MonoBook.php (modified) (history)
  • /trunk/phase3/skins/monobook/main.css (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/monobook/main.css
@@ -715,9 +715,7 @@
716716 padding: .5em .4em .4em .4em;
717717 text-align: center;
718718 }
719 -#p-search a {
720 - font-size: 95%;
721 -}
 719+
722720 /*
723721 ** the personal toolbar
724722 */
Index: trunk/phase3/skins/CologneBlue.php
@@ -299,8 +299,7 @@
300300 $s .= "<input type='text' id=\"searchInput{$this->searchboxes}\" class=\"mw-searchInput\" name=\"search\" size=\"14\" value=\""
301301 . htmlspecialchars(substr($search,0,256)) . "\" /><br />"
302302 . "<input type='submit' id=\"searchGoButton{$this->searchboxes}\" class=\"searchButton\" name=\"go\" value=\"" . htmlspecialchars( wfMsg( "searcharticle" ) ) . "\" />"
303 - . "<input type='submit' id=\"mw-searchButton{$this->searchboxes}\" class=\"searchButton\" name=\"fulltext\" value=\"" . htmlspecialchars( wfMsg( "search" ) ) . "\" />\n"
304 - . '<a href="$action" rel="search">' . wfMsg ('powersearch-legend') . '</a></form>';
 303+ . "<input type='submit' id=\"mw-searchButton{$this->searchboxes}\" class=\"searchButton\" name=\"fulltext\" value=\"" . htmlspecialchars( wfMsg( "search" ) ) . "\" /></form>";
305304
306305 // Ensure unique id's for search boxes made after the first
307306 $this->searchboxes = $this->searchboxes == '' ? 2 : $this->searchboxes + 1;
Index: trunk/phase3/skins/MonoBook.php
@@ -259,7 +259,6 @@
260260 ?> value="<?php $this->text('search') ?>"<?php } ?> />
261261 <input type='submit' name="go" class="searchButton" id="searchGoButton" value="<?php $this->msg('searcharticle') ?>"<?php echo $this->skin->tooltipAndAccesskey( 'search-go' ); ?> />&nbsp;
262262 <input type='submit' name="fulltext" class="searchButton" id="mw-searchButton" value="<?php $this->msg('searchbutton') ?>"<?php echo $this->skin->tooltipAndAccesskey( 'search-fulltext' ); ?> />
263 - <a href="<?php $this->text('searchaction') ?>" rel="search"><?php $this->msg('powersearch-legend') ?></a>
264263 </div></form>
265264 </div>
266265 </div>
Index: trunk/phase3/skins/Modern.php
@@ -256,7 +256,6 @@
257257 ?> value="<?php $this->text('search') ?>"<?php } ?> />
258258 <input type='submit' name="go" class="searchButton" id="searchGoButton" value="<?php $this->msg('searcharticle') ?>"<?php echo $this->skin->tooltipAndAccesskey( 'search-go' ); ?> />&nbsp;
259259 <input type='submit' name="fulltext" class="searchButton" id="mw-searchButton" value="<?php $this->msg('searchbutton') ?>"<?php echo $this->skin->tooltipAndAccesskey( 'search-fulltext' ); ?> />
260 - <a href="<?php $this->text('searchaction') ?>" rel="search"><?php $this->msg('powersearch-legend') ?></a>
261260 </div></form>
262261 </div><!-- pBody -->
263262 </div><!-- portlet -->
Index: trunk/phase3/includes/Skin.php
@@ -1148,8 +1148,7 @@
11491149 . '<input type="text" id="searchInput'.$this->searchboxes.'" name="search" size="19" value="'
11501150 . htmlspecialchars(substr($search,0,256)) . "\" />\n"
11511151 . '<input type="submit" name="go" value="' . wfMsg ('searcharticle') . '" />&nbsp;'
1152 - . '<input type="submit" name="fulltext" value="' . wfMsg ('searchbutton') . "\" />\n"
1153 - . '<a href="' . $this->escapeSearchLink() . '" rel="search">' . wfMsg ('powersearch-legend') . '</a></form>';
 1152+ . '<input type="submit" name="fulltext" value="' . wfMsg ('searchbutton') . "\" />\n</form>";
11541153
11551154 // Ensure unique id's for search boxes made after the first
11561155 $this->searchboxes = $this->searchboxes == '' ? 2 : $this->searchboxes + 1;
Index: trunk/phase3/RELEASE-NOTES
@@ -26,7 +26,6 @@
2727 === New features in 1.15 ===
2828
2929 * (bug 2242) Add an expiry time to temporary passwords
30 -* Added "Advanced search" link to the search form
3130 * Special:Upload can now have a custom upload message instead of uploadtext by
3231 passing "uploadmsg" parameter in the url
3332 * (bug 9947) Add PROTECTIONLEVEL parser function to return the protection level

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r45490* Added "Advanced search" link to the search formdanny_b04:56, 7 January 2009

Status & tagging log