r45743 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r45742‎ | r45743 | r45744 >
Date:19:41, 14 January 2009
Author:brion
Status:ok
Tags:
Comment:
Revert r45671 "Added "__\" magic word to eat up all whitespace and newlines to the next non-whitespace character, to facilitate writing readable template code where whitespace is significant."
Unplanned syntax change.
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/parser/Parser.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/parser/Parser.php
@@ -327,12 +327,6 @@
328328 $text = $this->internalParse( $text );
329329 $text = $this->mStripState->unstripGeneral( $text );
330330
331 - # To make wikitext easier to read where significant
332 - # whitespace is a problem, '__\' will be eaten up along with
333 - # all whitespace and newlines that follow it, up to the next
334 - # non-whitespace character. (Compare 'dnl' from m4.)
335 - $text = preg_replace('/__\\\\\s*/', '', $text);
336 -
337331 # Clean up special characters, only run once, next-to-last before doBlockLevels
338332 $fixtags = array(
339333 # french spaces, last one Guillemet-left
Index: trunk/phase3/RELEASE-NOTES
@@ -31,9 +31,6 @@
3232 passing "uploadmsg" parameter in the url
3333 * (bug 9947) Add PROTECTIONLEVEL parser function to return the protection level
3434 for the current page for a given action
35 -* Added "__\" magic word to eat up all whitespace and newlines to the next
36 - non-whitespace character, to facilitate writing readable template code where
37 - whitespace is significant.
3835 * (bug 17002) Add &minor= and &summary= as parameters in the url when editing,
3936 to automatically add a summary or a minor edit.
4037 * (bug 16852) padleft and padright now accept multiletter pad characters

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r45671krimpet07:45, 12 January 2009

Status & tagging log