r45718 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r45717‎ | r45718 | r45719 >
Date:21:51, 13 January 2009
Author:aaron
Status:resolved (Comments)
Tags:
Comment:
Check $wgLang->isRTL()
Modified paths:
  • /trunk/phase3/includes/specials/SpecialPreferences.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialPreferences.php
——@@ -1209,8 +1209,8 @@
12101210 $skin = $wgUser->getSkin();
12111211 $wgOut->addHTML( "
12121212 <div id='prefsubmit'>
1213 - <input type='submit' name='wpRestore' class='btnSavePrefs' style='float:right;' value=\"" .
1214 - wfMsgHtml( 'restoreprefs' ) . "\" />
 1213+ <input type='submit' name='wpRestore' class='btnSavePrefs' style=float:".
 1214+ ($wgLang->isRTL() ? 'left' : 'right') . " value=\"" . wfMsgHtml( 'restoreprefs' ) . "\" />
12151215 <input type='submit' name='wpSaveprefs' class='btnSavePrefs' value=\"" . wfMsgHtml( 'saveprefs' ) .
12161216 '"'.$skin->tooltipAndAccesskey('save')." />
12171217 <input type='submit' name='wpReset' value=\"" . wfMsgHtml( 'resetprefs' ) . "\" />

Comments

#Comment by Brion VIBBER (talk | contribs)   23:57, 14 January 2009

Looks better on RTL, but I notice it's got the tab order backwards -- when tabbing between fields, the 'restore' button is reached before the 'save' button, which is unexpected. Explicit tab indexes could be added, or this layout could be done with a table instead...

#Comment by Aaron Schulz (talk | contribs)   13:41, 16 January 2009

Uses a table now in r45761

Status & tagging log