r45704 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r45703‎ | r45704 | r45705 >
Date:15:42, 13 January 2009
Author:aaron
Status:resolved (Comments)
Tags:
Comment:
(bug 15391) catch DBQueryError too
Modified paths:
  • /trunk/phase3/includes/ExternalStore.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/ExternalStore.php
@@ -92,6 +92,8 @@
9393 $url = $store->store( $params, $data ); // Try to save the object
9494 } catch ( DBConnectionError $error ) {
9595 $url = false;
 96+ } catch( DBQueryError $error ) {
 97+ $url = false;
9698 }
9799 if ( $url ) {
98100 return $url; // Done!

Follow-up revisions

RevisionCommit summaryAuthorDate
r46391* (bug 15391) catch DBQueryErrors on external storage insertion. This avoids ...aaron21:41, 27 January 2009

Comments

#Comment by Brion VIBBER (talk | contribs)   21:39, 27 January 2009

release note

#Comment by Aaron Schulz (talk | contribs)   21:41, 27 January 2009

Done in r46391

Status & tagging log