r45692 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r45691‎ | r45692 | r45693 >
Date:01:50, 13 January 2009
Author:soxred93
Status:ok
Tags:
Comment:
(bug 17000) Special:RevisionDelete now checks if the database is locked before trying to delete the edit. Patch by FunPika
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/specials/SpecialRevisiondelete.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialRevisiondelete.php
@@ -9,6 +9,12 @@
1010
1111 function wfSpecialRevisiondelete( $par = null ) {
1212 global $wgOut, $wgRequest, $wgUser;
 13+
 14+ if ( wfReadOnly() ) {
 15+ $wgOut->readOnlyPage();
 16+ return;
 17+ }
 18+
1319 # Handle our many different possible input types
1420 $target = $wgRequest->getText( 'target' );
1521 $oldid = $wgRequest->getArray( 'oldid' );
Index: trunk/phase3/RELEASE-NOTES
@@ -40,6 +40,7 @@
4141 * Improving the efficiency by using -{A|xxx}- syntax (only applies on wiki with LanguageConverter class)
4242 * (bug 16968) Special:Upload no longer throws useless warnings.
4343 * (bug 15470) Special:Upload no longer force-capitalizes titles
 44+* (bug 17000) Special:RevisionDelete now checks if the database is locked before trying to delete the edit.
4445
4546 == API changes in 1.15 ==
4647 * (bug 16798) JSON encoding errors for some characters outside the BMP

Status & tagging log