r45665 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r45664‎ | r45665 | r45666 >
Date:12:12, 11 January 2009
Author:nikerabbit
Status:ok
Tags:
Comment:
* Skip optionals and ignored messages, so at least people don't translate them addicentally
Modified paths:
  • /trunk/extensions/Translate/TranslateEditAddons.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Translate/TranslateEditAddons.php
@@ -20,8 +20,11 @@
2121 if ( $group === null ) return true;
2222
2323 $defs = $group->getDefinitions();
 24+ $skip = array_merge( $group->getIgnored(), $group->getOptional() );
 25+
2426 $next = $prev = $def = null;
2527 foreach ( array_keys( $defs ) as $tkey ) {
 28+ if ( in_array( $tkey, $skip ) ) continue;
2629 // Keys can have mixed case, but they have to be unique in a case
2730 // insensitive manner. It is therefore safe and a must to use case
2831 // insensitive comparison method

Status & tagging log