r45629 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r45628‎ | r45629 | r45630 >
Date:02:30, 10 January 2009
Author:tstarling
Status:ok
Tags:
Comment:
* Tweaked docs
* Backported r45592, r45624
Modified paths:
  • /branches/REL1_14/phase3 (modified) (history)
  • /branches/REL1_14/phase3/HISTORY (modified) (history)
  • /branches/REL1_14/phase3/RELEASE-NOTES (modified) (history)
  • /branches/REL1_14/phase3/config/index.php (modified) (history)
  • /branches/REL1_14/phase3/includes/DefaultSettings.php (modified) (history)
  • /branches/REL1_14/phase3/includes/db/Database.php (modified) (history)
  • /branches/REL1_14/phase3/includes/db/DatabasePostgres.php (modified) (history)
  • /branches/REL1_14/phase3/includes/db/DatabaseSqlite.php (modified) (history)

Diff [purge]

Index: branches/REL1_14/phase3/HISTORY
@@ -1,5 +1,7 @@
22 Change notes from older releases. For current info see RELEASE-NOTES.
33
 4+== MediaWiki 1.13 ==
 5+
46 == Changes since 1.13.2 ==
57
68 David Remahl of Apple's Product Security team has identified a number of
Index: branches/REL1_14/phase3/includes/db/DatabasePostgres.php
@@ -1056,7 +1056,13 @@
10571057 */
10581058 function getServerVersion() {
10591059 $versionInfo = pg_version( $this->mConn );
1060 - $this->numeric_version = $versionInfo['server'];
 1060+ if ( isset( $versionInfo['server'] ) ) {
 1061+ $this->numeric_version = $versionInfo['server'];
 1062+ } else {
 1063+ // There's no way to identify the precise version before 7.4, but
 1064+ // it doesn't matter anyway since we're just going to give an error.
 1065+ $this->numeric_version = '7.3 or earlier';
 1066+ }
10611067 return $this->numeric_version;
10621068 }
10631069
Index: branches/REL1_14/phase3/includes/db/Database.php
@@ -922,7 +922,7 @@
923923 $row = $this->fetchRow( $res );
924924 if ( $row !== false ) {
925925 $this->freeResult( $res );
926 - return $row[0];
 926+ return reset( $row );
927927 } else {
928928 return false;
929929 }
Index: branches/REL1_14/phase3/includes/db/DatabaseSqlite.php
@@ -410,6 +410,14 @@
411411 return "SearchEngineDummy";
412412 }
413413
 414+ /**
 415+ * No-op version of deadlockLoop
 416+ */
 417+ public function deadlockLoop( /*...*/ ) {
 418+ $args = func_get_args();
 419+ $function = array_shift( $args );
 420+ return call_user_func_array( $function, $args );
 421+ }
414422 }
415423
416424 /**
Index: branches/REL1_14/phase3/includes/DefaultSettings.php
@@ -33,7 +33,7 @@
3434 }
3535
3636 /** MediaWiki version number */
37 -$wgVersion = '1.14rc1';
 37+$wgVersion = '1.14.0rc1';
3838
3939 /** Name of the site. It must be changed in LocalSettings.php */
4040 $wgSitename = 'MediaWiki';
Index: branches/REL1_14/phase3/config/index.php
@@ -894,7 +894,7 @@
895895 continue;
896896 }
897897
898 - print "<li>Connected to $myver";
 898+ print "<li>Connected to {$conf->DBtype} $myver";
899899 if ($conf->DBtype == 'mysql') {
900900 if( version_compare( $myver, "4.0.14" ) < 0 ) {
901901 print "</li>\n";
@@ -945,7 +945,7 @@
946946 $wgDatabase->selectDB( $wgDBname );
947947 }
948948 else if ($conf->DBtype == 'postgres') {
949 - if( version_compare( $myver, "PostgreSQL 8.0" ) < 0 ) {
 949+ if( version_compare( $myver, "8.0" ) < 0 ) {
950950 dieout( "<b>Postgres 8.0 or later is required</b>. Aborting." );
951951 }
952952 }
Index: branches/REL1_14/phase3/RELEASE-NOTES
@@ -5,7 +5,7 @@
66
77 == MediaWiki 1.14 ==
88
9 -This is a release candidate for the 2008 Q1 branch of MediaWiki.
 9+This is a release candidate for the 2009 Q1 branch of MediaWiki.
1010
1111 MediaWiki is now using a "continuous integration" development model with
1212 quarterly snapshot releases. The latest development code is always kept
Property changes on: branches/REL1_14/phase3
___________________________________________________________________
Name: svn:mergeinfo
1313 + /trunk/phase3:45592

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r45592* In selectField(), use reset($row) instead of $row[0] for compatibility with...tstarling03:53, 9 January 2009
r45624* (bug 16937) Show appropriate error message when someone attempts an install...tstarling00:53, 10 January 2009

Status & tagging log