r45591 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r45590‎ | r45591 | r45592 >
Date:00:32, 9 January 2009
Author:aaron
Status:ok
Tags:
Comment:
Fix for r45589: still patrol as before for reviewed edits
Modified paths:
  • /trunk/extensions/FlaggedRevs/FlaggedRevs.hooks.php (modified) (history)

Diff [purge]

Index: trunk/extensions/FlaggedRevs/FlaggedRevs.hooks.php
@@ -746,15 +746,18 @@
747747 if( empty($rc->mAttribs['rc_this_oldid']) ) {
748748 return true;
749749 }
750 - $patrol = $record = false;
751750 // Is the page reviewable?
752751 if( FlaggedRevs::isPageReviewable( $rc->getTitle() ) ) {
753752 # Note: pages in reviewable namespace with FR disabled
754753 # won't autopatrol. May or may not be useful...
755 - $patrol = FlaggedRevs::revIsFlagged( $rc->getTitle(), $rc->mAttribs['rc_this_oldid'],
756 - GAID_FOR_UPDATE );
 754+ if( FlaggedRevs::revIsFlagged($rc->getTitle(),$rc->mAttribs['rc_this_oldid'],GAID_FOR_UPDATE) ) {
 755+ RevisionReview::updateRecentChanges( $rc->getTitle(), $rc->mAttribs['rc_this_oldid'] );
 756+ }
 757+ return true;
 758+ }
757759 // Can this be patrolled?
758 - } else if( FlaggedRevs::isPagePatrollable( $rc->getTitle() ) ) {
 760+ $patrol = $record = false;
 761+ if( FlaggedRevs::isPagePatrollable( $rc->getTitle() ) ) {
759762 $patrol = $wgUser->isAllowed('autopatrolother') || $wgUser->isAllowed('bot');
760763 $record = true;
761764 } else {

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r45589(bug 16914) Autopatrol only the edit made, not previous ones; was using the w...aaron00:05, 9 January 2009

Status & tagging log