r45561 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r45560‎ | r45561 | r45562 >
Date:11:37, 8 January 2009
Author:ialex
Status:ok
Tags:
Comment:
Fix for r45527: put $talk def back at top since it's already used in the next line
Modified paths:
  • /trunk/extensions/NewUserMessage/NewUserMessage.class.php (modified) (history)

Diff [purge]

Index: trunk/extensions/NewUserMessage/NewUserMessage.class.php
@@ -16,13 +16,14 @@
1717 /*
1818 * Add the template message if the users talk page doesn't already exist
1919 */
20 - static function createNewUserMessage($user) {
21 - if (!$talk->exists()) {
 20+ static function createNewUserMessage( $user ) {
 21+ $talk = $user->getTalkPage();
 22+
 23+ if ( !$talk->exists() ) {
2224 global $wgUser, $wgNewUserMinorEdit, $wgNewUserSuppressRC;
2325
2426 $name = $user->getName();
2527 $realName = $user->getRealName();
26 - $talk = $user->getTalkPage();
2728
2829 wfLoadExtensionMessages( 'NewUserMessage' );
2930

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r45527Add user's real name as second template parameter. Based on suggestion by ano...siebrand21:58, 7 January 2009

Status & tagging log