r45553 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r45552‎ | r45553 | r45554 >
Date:07:29, 8 January 2009
Author:demon
Status:ok
Tags:
Comment:
Backport Http fix from r45549 to 1.14 branch.
Modified paths:
  • /branches/REL1_14/phase3/includes/HttpFunctions.php (modified) (history)

Diff [purge]

Index: branches/REL1_14/phase3/includes/HttpFunctions.php
@@ -56,8 +56,10 @@
5757
5858 curl_setopt( $c, CURLOPT_TIMEOUT, $timeout );
5959 curl_setopt( $c, CURLOPT_USERAGENT, self :: userAgent() );
60 - if ( $method == 'POST' )
 60+ if ( $method == 'POST' ) {
6161 curl_setopt( $c, CURLOPT_POST, true );
 62+ curl_setopt( $c, CURLOPT_POSTFIELDS, '' );
 63+ }
6264 else
6365 curl_setopt( $c, CURLOPT_CUSTOMREQUEST, $method );
6466

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r45549Fix odd edge case for POST Http::request()'s. I incidentally found this while...demon06:56, 8 January 2009

Status & tagging log