r45505 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r45504‎ | r45505 | r45506 >
Date:16:40, 7 January 2009
Author:raymond
Status:ok
Tags:
Comment:
Remove horizontal line bettwen input form and output.
Looks odd to me since we have the nice fieldsets.
Modified paths:
  • /trunk/phase3/includes/specials/SpecialAllpages.php (modified) (history)
  • /trunk/phase3/includes/specials/SpecialPrefixindex.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialAllpages.php
@@ -217,9 +217,9 @@
218218 $out2 .= '<tr valign="top"><td>' . $nsForm;
219219 $out2 .= '</td><td align="' . $align . '" style="font-size: smaller; margin-bottom: 1em;">' .
220220 $wgUser->getSkin()->makeKnownLinkObj( $this->getTitle(), wfMsgHtml ( 'allpages' ) );
221 - $out2 .= "</td></tr></table><hr />";
 221+ $out2 .= "</td></tr></table>";
222222 } else {
223 - $out2 = $nsForm . '<hr />';
 223+ $out2 = $nsForm;
224224 }
225225 }
226226 $wgOut->addHTML( $out2 . $out );
@@ -394,7 +394,7 @@
395395 wfMsgHtml( 'nextpage', htmlspecialchars( $t->getText() ) ), $q );
396396 $out2 .= ' | ' . $nextLink;
397397 }
398 - $out2 .= "</td></tr></table><hr />";
 398+ $out2 .= "</td></tr></table>";
399399 }
400400
401401 $wgOut->addHTML( $out2 . $out );
Index: trunk/phase3/includes/specials/SpecialPrefixindex.php
@@ -181,7 +181,7 @@
182182 "from=" . wfUrlEncode( $s->page_title ) .
183183 "&prefix=" . wfUrlEncode( $prefix ) . $namespaceparam );
184184 }
185 - $out2 .= "</td></tr></table><hr />";
 185+ $out2 .= "</td></tr></table>";
186186 }
187187
188188 $wgOut->addHTML( $out2 . $out );

Status & tagging log