r45312 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r45311‎ | r45312 | r45313 >
Date:11:07, 2 January 2009
Author:aaron
Status:ok
Tags:
Comment:
(bug 11330) Improper use of WebRequest::getIntOrNull()
Modified paths:
  • /trunk/phase3/includes/RawPage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/RawPage.php
@@ -34,7 +34,7 @@
3535 }
3636
3737 $ctype = $this->mRequest->getVal( 'ctype' );
38 - $smaxage = $this->mRequest->getIntOrNull( 'smaxage', $wgSquidMaxage );
 38+ $smaxage = $this->mRequest->getIntOrNull( 'smaxage' );
3939 $maxage = $this->mRequest->getInt( 'maxage', $wgSquidMaxage );
4040
4141 $this->mExpandTemplates = $this->mRequest->getVal( 'templates' ) === 'expand';

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r45160(bug 11330) Passing default to Request->getInt() is good enough, rather than ...aaron18:58, 29 December 2008
r45251Revert r45160 "(bug 11330) Passing default to Request->getInt() is good enoug...brion21:05, 31 December 2008

Status & tagging log