r45280 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r45279‎ | r45280 | r45281 >
Date:13:36, 1 January 2009
Author:raymond
Status:ok
Tags:
Comment:
* Add spaces between buttons, looks smarter
* Use Xml::fieldset function
Modified paths:
  • /trunk/phase3/includes/specials/SpecialUndelete.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialUndelete.php
@@ -1013,8 +1013,7 @@
10141014 $unsuppressBox = "";
10151015 }
10161016 $table =
1017 - Xml::openElement( 'fieldset' ) .
1018 - Xml::element( 'legend', null, wfMsg( 'undelete-fieldset-title' ) ).
 1017+ Xml::fieldset( wfMsg( 'undelete-fieldset-title' ) ) .
10191018 Xml::openElement( 'table', array( 'id' => 'mw-undelete-table' ) ) .
10201019 "<tr>
10211020 <td colspan='2'>" .
@@ -1032,8 +1031,8 @@
10331032 <tr>
10341033 <td>&nbsp;</td>
10351034 <td class='mw-submit'>" .
1036 - Xml::submitButton( wfMsg( 'undeletebtn' ), array( 'name' => 'restore', 'id' => 'mw-undelete-submit' ) ) .
1037 - Xml::element( 'input', array( 'type' => 'reset', 'value' => wfMsg( 'undeletereset' ), 'id' => 'mw-undelete-reset' ) ) .
 1035+ Xml::submitButton( wfMsg( 'undeletebtn' ), array( 'name' => 'restore', 'id' => 'mw-undelete-submit' ) ) . ' ' .
 1036+ Xml::element( 'input', array( 'type' => 'reset', 'value' => wfMsg( 'undeletereset' ), 'id' => 'mw-undelete-reset' ) ) . ' ' .
10381037 Xml::submitButton( wfMsg( 'undeleteinvert' ), array( 'name' => 'invert', 'id' => 'mw-undelete-invert' ) ) .
10391038 "</td>
10401039 </tr>" .

Status & tagging log