r45180 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r45179‎ | r45180 | r45181 >
Date:11:59, 30 December 2008
Author:aaron
Status:deferred
Tags:
Comment:
Remove more unused ES stuff
Modified paths:
  • /trunk/extensions/FlaggedRevs/FlaggedRevs.class.php (modified) (history)
  • /trunk/extensions/FlaggedRevs/FlaggedRevs.php (modified) (history)

Diff [purge]

Index: trunk/extensions/FlaggedRevs/FlaggedRevs.php
@@ -219,12 +219,6 @@
220220 $wgAddGroups['bureaucrat'][] = 'reviewer';
221221 $wgRemoveGroups['bureaucrat'][] = 'reviewer';
222222
223 -# If you want to use a storage group specifically for this
224 -# software, set this array
225 -# FIXME: this feature creates orphan blobs in the external storage table when
226 -# Special:RevisionReview updates a revision. It should not be used.
227 -$wgFlaggedRevsExternalStore = false;
228 -
229223 # Show reviews in recentchanges? Disabled by default, often spammy...
230224 $wgFlaggedRevsLogInRC = false;
231225
Index: trunk/extensions/FlaggedRevs/FlaggedRevs.class.php
@@ -7,7 +7,6 @@
88 protected static $loaded = false;
99 protected static $qualityVersions = false;
1010 protected static $pristineVersions = false;
11 - protected static $extStorage = false;
1211 protected static $includeVersionCache = array();
1312
1413 public static function load() {
@@ -50,13 +49,6 @@
5150 self::$pristineVersions = true;
5251 }
5352
54 - # FIXME: Special:RevisionReview creates orphan blobs when existing reviews
55 - # are updated. Disabling this feature for now. -- TS
56 - #global $wgFlaggedRevsExternalStore, $wgDefaultExternalStore;
57 - #self::$extStorage = $wgFlaggedRevsExternalStore ?
58 - # $wgFlaggedRevsExternalStore : $wgDefaultExternalStore;
59 - self::$extStorage = false;
60 -
6153 self::$loaded = true;
6254 }
6355
@@ -79,15 +71,6 @@
8072 self::load();
8173 return self::$pristineVersions;
8274 }
83 -
84 - /**
85 - * Get external storage array. Default to main storage.
86 - * @returns mixed (array/false)
87 - */
88 - public static function getExternalStorage() {
89 - self::load();
90 - return self::$extStorage;
91 - }
9275
9376 /**
9477 * Should this be using a simple icon-based UI?

Status & tagging log