r45172 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r45171‎ | r45172 | r45173 >
Date:02:36, 30 December 2008
Author:tstarling
Status:ok
Tags:
Comment:
Disabling ES text store due to a bug involving loss of referential integrity, specifically creation of orphans in the blobs table, where they are hard to detect and remove.
Modified paths:
  • /trunk/extensions/FlaggedRevs/FlaggedRevs.class.php (modified) (history)
  • /trunk/extensions/FlaggedRevs/FlaggedRevs.php (modified) (history)

Diff [purge]

Index: trunk/extensions/FlaggedRevs/FlaggedRevs.php
@@ -222,6 +222,8 @@
223223
224224 # If you want to use a storage group specifically for this
225225 # software, set this array
 226+# FIXME: this feature creates orphan blobs in the external storage table when
 227+# Special:RevisionReview updates a revision. It should not be used.
226228 $wgFlaggedRevsExternalStore = false;
227229
228230 # Show reviews in recentchanges? Disabled by default, often spammy...
Index: trunk/extensions/FlaggedRevs/FlaggedRevs.class.php
@@ -49,10 +49,14 @@
5050 if( $wgFlaggedRevValues >= $wgFlaggedRevPristine ) {
5151 self::$pristineVersions = true;
5252 }
53 - global $wgFlaggedRevsExternalStore, $wgDefaultExternalStore;
54 - self::$extStorage = $wgFlaggedRevsExternalStore ?
55 - $wgFlaggedRevsExternalStore : $wgDefaultExternalStore;
5653
 54+ # FIXME: Special:RevisionReview creates orphan blobs when existing reviews
 55+ # are updated. Disabling this feature for now. -- TS
 56+ #global $wgFlaggedRevsExternalStore, $wgDefaultExternalStore;
 57+ #self::$extStorage = $wgFlaggedRevsExternalStore ?
 58+ # $wgFlaggedRevsExternalStore : $wgDefaultExternalStore;
 59+ self::$extStorage = false;
 60+
5761 self::$loaded = true;
5862 }
5963

Status & tagging log