r45164 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r45163‎ | r45164 | r45165 >
Date:19:27, 29 December 2008
Author:purodha
Status:deferred
Tags:
Comment:
FIXME: number of good images should be added, too.
Modified paths:
  • /trunk/extensions/SmoothGallery/SmoothGalleryClass.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SmoothGallery/SmoothGalleryClass.php
@@ -29,12 +29,12 @@
3030 $error = wfMsg( "smoothgallery-error" );
3131
3232 if ( isset( $galleryArray["missing_images"] ) && isset( $galleryArray["invalid_images"] ) ) {
33 - $error .= wfMsg( "smoothgallery-no-images", implode( ", " , $galleryArray["missing_images"] , count($galleryArray["missing_images"]) , count($galleryArray["missing_images"]) + count($galleryArray["invalid_images"]) ) );
 33+ $error .= wfMsg( "smoothgallery-no-images", implode( ", " , $galleryArray["missing_images"] , count($galleryArray["missing_images"]) , count($galleryArray["missing_images"]) + count($galleryArray["invalid_images"]) ) ); // FIXME: 3rd (last) parameter should have the number of good images added.
3434 $error .= wfMsg( "smoothgallery-invalid-images", implode( ", " , $galleryArray["invalid_images"] , count($galleryArray["invalid_images"]) ) );
3535 } else if ( isset( $galleryArray["invalid_images"] ) ) {
3636 $error .= wfMsg( "smoothgallery-invalid-images", implode( ", " , $galleryArray["invalid_images"] , count($galleryArray["invalid_images"]) ) );
3737 } else if ( isset( $galleryArray["missing_images"] ) ) {
38 - $error .= wfMsg( "smoothgallery-no-images", implode( ", " , $galleryArray["missing_images"] , count($galleryArray["missing_images"]) , count($galleryArray["missing_images"]) ) );
 38+ $error .= wfMsg( "smoothgallery-no-images", implode( ", " , $galleryArray["missing_images"] , count($galleryArray["missing_images"]) , count($galleryArray["missing_images"]) ) ); // FIXME: 3rd (last) parameter should have the number of good images added.
3939 } else {
4040 $error .= wfMsg( "smoothgallery-not-found" );
4141 }

Status & tagging log