r45129 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r45128‎ | r45129 | r45130 >
Date:15:17, 28 December 2008
Author:aaron
Status:ok
Tags:
Comment:
Fix doc comment, sigh
Modified paths:
  • /trunk/phase3/includes/HTMLFileCache.php (modified) (history)
  • /trunk/phase3/index.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/HTMLFileCache.php
@@ -131,7 +131,8 @@
132132 wfDebug(" loadFromFileCache()\n");
133133
134134 $filename = $this->fileCacheName();
135 - // Raw pages will handle control on their own
 135+ // Raw pages should handle cache control on their own,
 136+ // even when using file cache. This reduces hits from clients.
136137 if( $this->mType !== 'raw' )
137138 $wgOut->sendCacheControl();
138139
Index: trunk/phase3/index.php
@@ -75,8 +75,8 @@
7676
7777 if( $wgUseFileCache && isset($wgTitle) ) {
7878 wfProfileIn( 'main-try-filecache' );
79 - // Raw pages should handle control on their own
80 - // even when using file cache.
 79+ // Raw pages should handle cache control on their own,
 80+ // even when using file cache. This reduces hits from clients.
8181 if( $action != 'raw' && HTMLFileCache::useFileCache() ) {
8282 /* Try low-level file cache hit */
8383 $cache = new HTMLFileCache( $wgTitle, $action );

Status & tagging log