r45035 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r45034‎ | r45035 | r45036 >
Date:18:22, 25 December 2008
Author:ialex
Status:deferred
Tags:
Comment:
Per r45031: removed skin names localisation from Special:Magic
Modified paths:
  • /trunk/extensions/Translate/SpecialMagic.php (modified) (history)
  • /trunk/extensions/Translate/Translate.i18n.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Translate/Translate.i18n.php
@@ -76,11 +76,11 @@
7777 'translate-edit-goto-list' => 'Back to the list',
7878
7979 'translate-magic-pagename' => 'Extended MediaWiki translation',
80 - 'translate-magic-help' => 'You can translate special pages aliases, magic words, skin names and namespace names.
 80+ 'translate-magic-help' => 'You can translate special pages aliases, magic words and namespace names.
8181
8282 Special page aliases and magic words can have multiple translations.
8383 Translations are separated by a comma (,).
84 -Skin names and namespaces can have only one translation.
 84+Namespaces can have only one translation.
8585
8686 In namespace translations <tt>$1 talk</tt> is special. <tt>$1</tt> is replaced with sitename (for example <tt>{{SITENAME}} talk</tt>).
8787 If it is not possible in your language to form valid expression without changing sitename, please contact a developer.
@@ -103,7 +103,6 @@
104104
105105 'translate-magic-special' => 'Special page aliases',
106106 'translate-magic-words' => 'Magic words',
107 - 'translate-magic-skin' => 'Skin names',
108107 'translate-magic-namespace' => 'Namespace names',
109108
110109 'translationchanges' => 'Translation changes',
Index: trunk/extensions/Translate/SpecialMagic.php
@@ -9,7 +9,6 @@
1010 /** Message prefix for translations */
1111 const MSG = 'translate-magic-';
1212
13 - const MODULE_SKIN = 'skin';
1413 const MODULE_MAGIC = 'words';
1514 const MODULE_SPECIAL = 'special';
1615 const MODULE_NAMESPACE = 'namespace';
@@ -17,7 +16,6 @@
1817 /** List of supported modules */
1918 private $aModules = array(
2019 self::MODULE_SPECIAL,
21 - self::MODULE_SKIN,
2220 self::MODULE_NAMESPACE,
2321 self::MODULE_MAGIC
2422 );
@@ -138,9 +136,6 @@
139137 case self::MODULE_MAGIC:
140138 $o = new MagicWordsCM( $this->options['language'] );
141139 break;
142 - case self::MODULE_SKIN:
143 - $o = new SkinNamesCM( $this->options['language'] );
144 - break;
145140 case self::MODULE_NAMESPACE:
146141 $o = new NamespaceCM( $this->options['language'] );
147142 break;
@@ -623,21 +618,6 @@
624619
625620 }
626621
627 -class SkinNamesCM extends ComplexMessages {
628 - protected $id = SpecialMagic::MODULE_SKIN;
629 - protected $elementsInArray = false;
630 - protected $databaseMsg = 'sp-translate-data-SkinNames';
631 -
632 - public function __construct( $code ) {
633 - parent::__construct( $code );
634 - $this->data['Mediawiki Core'] = array(
635 - 'var' => 'skinNames',
636 - 'file' => Language::getMessagesFileName( '%CODE%' ),
637 - 'code' => false,
638 - );
639 - }
640 -}
641 -
642622 class MagicWordsCM extends ComplexMessages {
643623 protected $id = SpecialMagic::MODULE_MAGIC;
644624 protected $firstMagic = true;

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r45031Per Nikerabbit and Siebrand: removed $skinNames from localisation files and r...ialex18:00, 25 December 2008

Status & tagging log