r44999 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r44998‎ | r44999 | r45000 >
Date:14:51, 24 December 2008
Author:siebrand
Status:deferred
Tags:
Comment:
Add plural for 'tasks_see_your_assignments', and 'tasks_my_assignments'. Thanks to Werdna, Nikerabbit and IAlex for the help.
Modified paths:
  • /trunk/extensions/Tasks/Tasks.i18n.php (modified) (history)
  • /trunk/extensions/Tasks/Tasks.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Tasks/Tasks.i18n.php
@@ -58,8 +58,8 @@
5959 'tasks_event_on_creation_anon' => "check",
6060 'tasks_on_creation_comment' => "Automatic task, generated on page creation",
6161 'tasks_link_your_assignments' => "open assignments",
62 - 'tasks_see_your_assignments' => "You currently have $1 open assignments. See your $2.",
63 - 'tasks_my_assignments' => "Your current assignments",
 62+ 'tasks_see_your_assignments' => "You currently have $1 open {{PLURAL:$1|assignment|assignments}}. See your $2.",
 63+ 'tasks_my_assignments' => "Your current {{PLURAL:$1|assignment|assignments}}",
6464 'tasks_table_header_page' => "Page",
6565 'tasks_you_have_no_assignments' => "You have no open assignments",
6666 'tasks_search_form_title' => "Search",
Index: trunk/extensions/Tasks/Tasks.php
@@ -1362,7 +1362,7 @@
13631363 if( count( $tasks ) == 0 ) {
13641364 $out .= '<p>' . wfMsgHTML( 'tasks_you_have_no_assignments' ) . '</p>';
13651365 } else {
1366 - $out .= '<h2>' . wfMsgHTML( 'tasks_my_assignments' ) . "</h2>\n"
 1366+ $out .= '<h2>' . wfMsgExt( 'tasks_my_assignments', array( 'escape', 'parsemag' ), count( $tasks ) ) . "</h2>\n"
13671367 . '<br /><table border="1" cellspacing="1" cellpadding="2">'
13681368 . '<tr>' . wfTaskExtensionGetTableHeader( true ) . '</tr>'
13691369 ;
@@ -1395,7 +1395,7 @@
13961396 if( $data->num == 0 ) {
13971397 $out .= wfMsgHTML( 'tasks_you_have_no_assignments' ) . '.' ;
13981398 } else {
1399 - $out .= wfMsgHTML( 'tasks_see_your_assignments', $data->num, $link ) ;
 1399+ $out .= wfMsgExt( 'tasks_see_your_assignments', array( 'escape', 'parsemag' ), $data->num, $link ) ;
14001400 }
14011401 $out .= '</p>';
14021402

Status & tagging log