r44998 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r44997‎ | r44998 | r44999 >
Date:13:55, 24 December 2008
Author:siebrand
Status:deferred
Tags:
Comment:
Support plural in 'securepasswords-minlength'.
Modified paths:
  • /trunk/extensions/SecurePasswords/SecurePasswords.i18n.php (modified) (history)
  • /trunk/extensions/SecurePasswords/SecurePasswords.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SecurePasswords/SecurePasswords.i18n.php
@@ -10,12 +10,13 @@
1111 */
1212 $messages['en'] = array(
1313 'securepasswords-desc' => 'Creates more secure password hashes and adds a password strength checker',
14 - 'securepasswords-valid' => 'Your password is invalid or too short. It must:',
15 - 'securepasswords-minlength' => 'be at least $1 characters long',
 14+ 'securepasswords-valid' => 'Your password is invalid or too short.
 15+It must:',
 16+ 'securepasswords-minlength' => 'be at least $1 {{PLURAL:$1|character|characters}} long',
1617 'securepasswords-lowercase' => 'contain at least 1 lowercase letter',
1718 'securepasswords-uppercase' => 'contain at least 1 uppercase letter',
1819 'securepasswords-digit' => 'contain at least 1 digit',
19 - 'securepasswords-special' => 'contain at least 1 special character (Special characters are: $1)',
 20+ 'securepasswords-special' => 'contain at least 1 special character (special characters are: $1)',
2021 'securepasswords-username' => 'be different from your username',
2122 'securepasswords-word' => 'not be a word',
2223 );
Index: trunk/extensions/SecurePasswords/SecurePasswords.php
@@ -27,7 +27,7 @@
2828 'name' => 'SecurePasswords',
2929 'author' => 'Ryan Schmidt',
3030 'url' => 'http://www.mediawiki.org/wiki/Extension:SecurePasswords',
31 - 'version' => '1.1',
 31+ 'version' => '1.1.1',
3232 'svn-date' => '$LastChangedDate$',
3333 'svn-revision' => '$LastChangedRevision$',
3434 'description' => 'Creates more secure password hashes and adds a password strength checker',
@@ -330,7 +330,7 @@
331331 wfLoadExtensionMessages('SecurePasswords');
332332 $key = 'securepasswords-password';
333333 $msg = wfMsg( 'securepasswords-valid' ) . ' ';
334 - $msg .= wfMsg( 'securepasswords-minlength', $wgValidPasswords['minlength'] );
 334+ $msg .= wfMsgExt( 'securepasswords-minlength', array( 'parsemag' ), $wgValidPasswords['minlength'] );
335335 if( $wgValidPasswords['lowercase'] ) {
336336 $msg .= ', ' . wfMsg( 'securepasswords-lowercase' );
337337 }

Status & tagging log