r44959 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r44958‎ | r44959 | r44960 >
Date:17:58, 23 December 2008
Author:brion
Status:ok
Tags:
Comment:
Cleanup for r44700 -- work on a clone of $wgTitle instead of modifying the fragment on the global object, which interferes with some other generated links outside the pager.
Modified paths:
  • /trunk/phase3/includes/ImagePage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/ImagePage.php
@@ -965,13 +965,17 @@
966966 class ImageHistoryPseudoPager extends ReverseChronologicalPager {
967967 function __construct( $imagePage ) {
968968 parent::__construct();
969 - $this->mImagePage =& $imagePage;
970 - $this->mTitle = $imagePage->getTitle();
 969+ $this->mImagePage = $imagePage;
 970+ $this->mTitle = clone( $imagePage->getTitle() );
971971 $this->mTitle->setFragment( '#filehistory' );
972972 $this->mImg = NULL;
973973 $this->mHist = array();
974974 $this->mRange = array( 0, 0 ); // display range
975975 }
 976+
 977+ function getTitle() {
 978+ return $this->mTitle;
 979+ }
976980
977981 function getQueryInfo() {
978982 return false;

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r44700Add fragment to nav links to set locationaaron01:35, 17 December 2008

Status & tagging log