r44956 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r44955‎ | r44956 | r44957 >
Date:17:14, 23 December 2008
Author:ialex
Status:ok
Tags:
Comment:
* Like r44911 but for MediaWiki:Difference message: switching from raw HTML to wiki text
* Whitespaces tweaks
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/diff/DifferenceEngine.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/diff/DifferenceEngine.php
@@ -145,7 +145,7 @@
146146 } else {
147147 $wgOut->setPageTitle( $oldTitle . ', ' . $newTitle );
148148 }
149 - $wgOut->setSubtitle( wfMsg( 'difference' ) );
 149+ $wgOut->setSubtitle( wfMsgExt( 'difference', array( 'parseinline' ) ) );
150150 $wgOut->setRobotPolicy( 'noindex,nofollow' );
151151
152152 if ( !( $this->mOldPage->userCanRead() && $this->mNewPage->userCanRead() ) ) {
@@ -219,11 +219,11 @@
220220 $newminor = '';
221221
222222 if ($this->mOldRev->mMinorEdit == 1) {
223 - $oldminor = Xml::span( wfMsg( 'minoreditletter'), 'minor' ) . ' ';
 223+ $oldminor = Xml::span( wfMsg( 'minoreditletter' ), 'minor' ) . ' ';
224224 }
225225
226226 if ($this->mNewRev->mMinorEdit == 1) {
227 - $newminor = Xml::span( wfMsg( 'minoreditletter'), 'minor' ) . ' ';
 227+ $newminor = Xml::span( wfMsg( 'minoreditletter' ), 'minor' ) . ' ';
228228 }
229229
230230 $rdel = ''; $ldel = '';
@@ -231,10 +231,10 @@
232232 $revdel = SpecialPage::getTitleFor( 'Revisiondelete' );
233233 if( !$this->mOldRev->userCan( Revision::DELETED_RESTRICTED ) ) {
234234 // If revision was hidden from sysops
235 - $ldel = wfMsgHtml('rev-delundel');
 235+ $ldel = wfMsgHtml( 'rev-delundel' );
236236 } else {
237237 $ldel = $sk->makeKnownLinkObj( $revdel,
238 - wfMsgHtml('rev-delundel'),
 238+ wfMsgHtml( 'rev-delundel' ),
239239 'target=' . urlencode( $this->mOldRev->mTitle->getPrefixedDbkey() ) .
240240 '&oldid=' . urlencode( $this->mOldRev->getId() ) );
241241 // Bolden oversighted content
@@ -245,13 +245,13 @@
246246 // We don't currently handle well changing the top revision's settings
247247 if( $this->mNewRev->isCurrent() ) {
248248 // If revision was hidden from sysops
249 - $rdel = wfMsgHtml('rev-delundel');
 249+ $rdel = wfMsgHtml( 'rev-delundel' );
250250 } else if( !$this->mNewRev->userCan( Revision::DELETED_RESTRICTED ) ) {
251251 // If revision was hidden from sysops
252 - $rdel = wfMsgHtml('rev-delundel');
 252+ $rdel = wfMsgHtml( 'rev-delundel' );
253253 } else {
254254 $rdel = $sk->makeKnownLinkObj( $revdel,
255 - wfMsgHtml('rev-delundel'),
 255+ wfMsgHtml( 'rev-delundel' ),
256256 'target=' . urlencode( $this->mNewRev->mTitle->getPrefixedDbkey() ) .
257257 '&oldid=' . urlencode( $this->mNewRev->getId() ) );
258258 // Bolden oversighted content
@@ -442,7 +442,7 @@
443443
444444 $wgOut->addHTML( $header );
445445
446 - $wgOut->setSubtitle( wfMsg( 'difference' ) );
 446+ $wgOut->setSubtitle( wfMsgExt( 'difference', array( 'parseinline' ) ) );
447447 $wgOut->setRobotPolicy( 'noindex,nofollow' );
448448
449449 wfProfileOut( __METHOD__ );
@@ -668,7 +668,7 @@
669669
670670 function localiseLineNumbersCb( $matches ) {
671671 global $wgLang;
672 - return wfMsgExt( 'lineno', array('parseinline'), $wgLang->formatNum( $matches[1] ) );
 672+ return wfMsgExt( 'lineno', array( 'parseinline' ), $wgLang->formatNum( $matches[1] ) );
673673 }
674674
675675
Index: trunk/phase3/RELEASE-NOTES
@@ -444,8 +444,8 @@
445445 * Section anchors now have an "id" attribute as well as a "name" attribute,
446446 even when Tidy is not used
447447 * (bug 16026) revision-info, revision-info-current, cannotdelete,
448 - redirectedfrom and historywarning messages now use Wiki text rather than raw
449 - HTML markup
 448+ redirectedfrom, historywarning and difference messages now use Wiki text
 449+ rather than raw HTML markup
450450 * (bug 13835) Fix rendering of {{filepath:Wiki.png|nowiki}}
451451
452452 === API changes in 1.14 ===

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r44911Switching some message from raw HTML to wiki (part of this commit fixes bug 1......ialex18:30, 22 December 2008

Status & tagging log