r44878 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r44877‎ | r44878 | r44879 >
Date:20:17, 21 December 2008
Author:aaron
Status:deferred
Tags:
Comment:
Use makeTitleSafe()
Modified paths:
  • /trunk/extensions/FlaggedRevs/FlaggedArticle.php (modified) (history)

Diff [purge]

Index: trunk/extensions/FlaggedRevs/FlaggedArticle.php
@@ -981,7 +981,7 @@
982982 }
983983 $tmpChanges = array();
984984 while( $row = $dbr->fetchObject( $ret ) ) {
985 - $title = Title::makeTitle( $row->ft_namespace, $row->ft_title );
 985+ $title = Title::makeTitleSafe( $row->ft_namespace, $row->ft_title );
986986 $revIdDraft = $row->page_latest;
987987 // stable time -> time when reviewed (unless the other is newer)
988988 $revIdStable = isset($row->fp_stable) && $row->fp_stable >= $row->ft_tmp_rev_id ?
@@ -1030,7 +1030,7 @@
10311031 }
10321032 $imgChanges = array();
10331033 while( $row = $dbr->fetchObject( $ret ) ) {
1034 - $title = Title::makeTitle( NS_FILE, $row->fi_name );
 1034+ $title = Title::makeTitleSafe( NS_FILE, $row->fi_name );
10351035 // stable time -> time when reviewed (unless the other is newer)
10361036 $timestamp = isset($row->fr_img_timestamp) && $row->fr_img_timestamp >= $row->fi_img_timestamp ?
10371037 $row->fr_img_timestamp : $row->fi_img_timestamp;

Status & tagging log