r44865 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r44864‎ | r44865 | r44866 >
Date:02:29, 21 December 2008
Author:aaron
Status:ok
Tags:
Comment:
(bug 16728) CodeReview showed an incorrect number of notes when doing a path search
Modified paths:
  • /trunk/extensions/CodeReview/CodeRevisionListView.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CodeReview/CodeRevisionListView.php
@@ -114,7 +114,7 @@
115115 return array(
116116 $this->getDefaultSort() => wfMsg( 'code-field-id' ),
117117 'cr_status' => wfMsg( 'code-field-status' ),
118 - 'COUNT(cc_rev_id)' => wfMsg( 'code-field-comments' ),
 118+ 'COUNT( DISTINCT cc_id)' => wfMsg( 'code-field-comments' ),
119119 'cr_path' => wfMsg( 'code-field-path' ),
120120 'cr_message' => wfMsg( 'code-field-message' ),
121121 'cr_author' => wfMsg( 'code-field-author' ),
@@ -142,7 +142,7 @@
143143 case 'cr_timestamp':
144144 global $wgLang;
145145 return $wgLang->timeanddate( $value, true );
146 - case 'COUNT(cc_rev_id)':
 146+ case 'COUNT( DISTINCT cc_id)':
147147 return intval( $value );
148148 case 'cr_path':
149149 return Xml::element('div', array( 'title' => (string)$value ),

Status & tagging log