r44750 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r44749‎ | r44750 | r44751 >
Date:02:57, 18 December 2008
Author:tstarling
Status:deferred
Tags:
Comment:
* Force re-export on every invocation, don't use existing directories. Otherwise a server-side or client-side abort might cause a partial dump to be created. Tested server-side aborts, they cause a non-zero exit status from svn and so should be dealt with gracefully.
* Use svn+ssh for export instead of http
Modified paths:
  • /trunk/release-tools/make-release (modified) (history)

Diff [purge]

Index: trunk/release-tools/make-release
@@ -146,16 +146,13 @@
147147 return hash.hexdigest()
148148
149149 def export(branch, dir):
150 - if os.path.exists(dir):
151 - print "The directory " + dir + " already exists, I'm assuming it is still valid"
152 - else:
153 - print "Exporting %s..." % (branch)
154 - proc = subprocess.Popen(['svn', 'export', '-q',
155 - 'http://svn.wikimedia.org/svnroot/mediawiki/' + branch + '/phase3', dir])
156 - if proc.wait() != 0:
157 - print "svn export failed, exiting"
158 - sys.exit(1)
159 - print "Done"
 150+ print "Exporting %s..." % (branch)
 151+ proc = subprocess.Popen(['svn', 'export', '-q', '--force',
 152+ 'svn+ssh://svn.wikimedia.org/svnroot/mediawiki/' + branch + '/phase3', dir])
 153+ if proc.wait() != 0:
 154+ print "svn export failed, exiting"
 155+ sys.exit(1)
 156+ print "Done"
160157
161158 def makePatch(patchFileName, dir1, dir2, type):
162159 patchFile = open(patchFileName, 'w')

Status & tagging log