r44744 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r44743‎ | r44744 | r44745 >
Date:00:22, 18 December 2008
Author:werdna
Status:ok
Tags:
Comment:
Allow array() to be saved. This will occur legitimately when you want to restore all settings to defaults.
Modified paths:
  • /trunk/extensions/Configure/Configure.obj.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Configure/Configure.obj.php
@@ -254,7 +254,7 @@
255255 * @return bool true on success
256256 */
257257 public function saveNewSettings( $settings, $wiki = false, $reason = '' ) {
258 - if ( !is_array( $settings ) || $settings === array() )
 258+ if ( !is_array( $settings ) )
259259 # hmmm
260260 return false;
261261

Status & tagging log