r44733 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r44732‎ | r44733 | r44734 >
Date:20:48, 17 December 2008
Author:bigsmoke
Status:deferred
Tags:
Comment:
In SemanticGallery extension, replaced require_once() with $wgAutoloadClasses as per Tim Starling's request.

Also, added a missing global declaration in semanticGaller_Setup() function
and bumped up version.
Modified paths:
  • /trunk/extensions/SemanticGallery/SemanticGallery.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticGallery/SemanticGallery.php
@@ -7,19 +7,19 @@
88
99 function semanticGallery_Setup()
1010 {
11 - global $wgParser, $wgHooks;
 11+ global $wgExtensionCredits, $wgAutoloadClasses;
1212
1313 // credits
1414 $wgExtensionCredits['parserhook'][] = array(
1515 'name' => 'Semantic Gallery',
16 - 'version' => '0.1.1',
 16+ 'version' => '0.3.1',
1717 'author' => array( 'Rowan Rodrik van der Molen' ),
1818 'url' => 'http://www.mediawiki.org/wiki/Extension:Semantic_Gallery',
1919 'description' => 'Adds a gallery output format to SMW inline queries',
2020 'descriptionmsg' => 'semanticgallery-desc',
2121 );
2222
23 - require_once('SG_ResultPrinter.php');
 23+ $wgAutoloadClasses['SemanticGallery_ResultPrinter'] = dirname(__FILE__).'/SG_ResultPrinter.php';
2424
2525 // global variable introduced in SMW 1.2.2
2626 global $smwgResultFormats;

Status & tagging log