r44711 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r44710‎ | r44711 | r44712 >
Date:08:55, 17 December 2008
Author:nikerabbit
Status:ok
Tags:
Comment:
* Some encoding issues
Modified paths:
  • /trunk/extensions/Call/Call_body.php (modified) (history)
  • /trunk/extensions/GoogleAdSense/GoogleAdSense.class.php (modified) (history)
  • /trunk/extensions/Randomrootpage/Randomrootpage.php (modified) (history)
  • /trunk/extensions/SemanticGoogleMaps/SGM_QueryPrinter.php (modified) (history)
  • /trunk/extensions/geo/geo.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Randomrootpage/Randomrootpage.php
@@ -6,7 +6,7 @@
77 * @addtogroup Extensions
88 *
99 * @author Hojjat (aka Huji) <huji.huji@gmail.com>
10 - * @copyright Copyright � 2008, Hojjat (aka Huji)
 10+ * @copyright Copyright © 2008, Hojjat (aka Huji)
1111 * @license http://www.gnu.org/copyleft/gpl.html GNU General Public License 2.0 or later
1212 */
1313
Index: trunk/extensions/Call/Call_body.php
@@ -15,7 +15,7 @@
1616 * @version 0.5
1717 * changed algorithm to recoignize parameters
1818 * @version 0.6
19 - * added a mechanism to save the called template�s raw text to a new article
 19+ * added a mechanism to save the called template's raw text to a new article
2020 * when doing this we replace symbols in the raw text which parameter names from our call by the values of these parameters
2121 * Call/abc,saveAsPage=xyz,foo=bar
2222 * will tale the raw text of "Template:Abc", replace all occurencies of 'foo' by 'bar' and save the result as a normal
Index: trunk/extensions/SemanticGoogleMaps/SGM_QueryPrinter.php
@@ -3,7 +3,7 @@
44 /**
55 * Print query results in a Google Map. Based on Google Maps API code
66 * written by Robert Buzink and query results printing code written by
7 - * Markus Kr�tzsch.
 7+ * Markus Krötzsch.
88 *
99 * @author Yaron Koren
1010 */
Index: trunk/extensions/geo/geo.php
@@ -165,7 +165,7 @@
166166 $filename = $gisbaseurl."?maparea=" . $arg. "&action=raw" ;
167167 $handle = fopen($filename, "r");
168168 $contents = '';
169 - # *EK* � couldn't get this to work...
 169+ # *EK* -- couldn't get this to work...
170170 while (!feof($handle))
171171 $contents .= fread($handle, 256*1024);
172172 fclose($handle);
Index: trunk/extensions/GoogleAdSense/GoogleAdSense.class.php
@@ -14,6 +14,7 @@
1515 $wgGoogleAdSenseSlot, $wgGoogleAdSenseSrc,
1616 $wgGoogleAdSenseAnonOnly, $wgUser;
1717
 18+
1819 // Return $bar unchanged if not all values have been set.
1920 // FIXME: signal incorrect configuration nicely?
2021 if( $wgGoogleAdSenseClient == 'none' || $wgGoogleAdSenseSlot == 'none' || $wgGoogleAdSenseID == 'none' )

Status & tagging log