r44644 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r44643‎ | r44644 | r44645 >
Date:01:05, 16 December 2008
Author:brion
Status:ok
Tags:
Comment:
Run subversion proxy junk through PHP serialization instead of JSON... the json decoder seems a little unreliable in PHP for some inputs, like freaking out over nulls in a string.
Most confusing of all, sometimes it fails out by returning the raw JSON input as the result instead of failing sensibly with false or null return. :P
Modified paths:
  • /trunk/tools/codereview-proxy/index.php (modified) (history)

Diff [purge]

Index: trunk/tools/codereview-proxy/index.php
@@ -5,10 +5,10 @@
66 // Subversion server, which is in a separate data center.
77
88 ini_set( 'display_errors', false);
9 -header('Content-type: application/x-json');
 9+header('Content-type: application/x-php-serialized');
1010
1111 $data = runAction( "http://svn.wikimedia.org/svnroot/mediawiki" );
12 -echo json_encode( $data );
 12+echo serialize( $data );
1313
1414 function inputStr( $key, $default=null ) {
1515 if( isset( $_GET[$key] ) ) {

Status & tagging log