r44595 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r44594‎ | r44595 | r44596 >
Date:21:15, 14 December 2008
Author:aaron
Status:deferred
Tags:
Comment:
Remove unused field
Modified paths:
  • /trunk/extensions/FlaggedRevs/specialpages/OldReviewedPages_body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/FlaggedRevs/specialpages/OldReviewedPages_body.php
@@ -269,10 +269,12 @@
270270 $conds = $this->mConds;
271271 $tables = array( 'flaggedpages', 'page', 'revision' );
272272 $fields = array('page_namespace','page_title','page_len','fp_stable','fp_quality',
273 - 'fp_page_id','fp_pending_since','rev_len');
 273+ 'fp_pending_since','rev_len');
274274 $conds[] = 'page_id = fp_page_id';
 275+ # Overconstrain rev_page to force PK use
275276 $conds[] = 'rev_page = fp_page_id AND rev_id = fp_stable';
276277 $conds[] = 'fp_pending_since IS NOT NULL';
 278+ # Filter namespace
277279 $conds['page_namespace'] = $this->namespace;
278280 $useIndex = array('flaggedpages' => 'fp_pending_since','page' => 'PRIMARY');
279281 # Filter by category

Status & tagging log