r44557 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r44556‎ | r44557 | r44558 >
Date:03:43, 14 December 2008
Author:vyznev
Status:ok
Tags:
Comment:
Followup to r44525: remove the broken $flags parameter from RepoGroup::findFiles() too.
Modified paths:
  • /trunk/phase3/includes/filerepo/RepoGroup.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/filerepo/RepoGroup.php
@@ -82,7 +82,7 @@
8383 }
8484 return false;
8585 }
86 - function findFiles( $titles, $flags = 0 ) {
 86+ function findFiles( $titles ) {
8787 if ( !$this->reposInitialised ) {
8888 $this->initialiseRepos();
8989 }
@@ -95,7 +95,7 @@
9696 $titleObjs[$title->getDBkey()] = $title;
9797 }
9898
99 - $images = $this->localRepo->findFiles( $titleObjs, $flags );
 99+ $images = $this->localRepo->findFiles( $titleObjs );
100100
101101 foreach ( $this->foreignRepos as $repo ) {
102102 // Remove found files from $titleObjs
@@ -103,7 +103,7 @@
104104 if ( isset( $titleObjs[$name] ) )
105105 unset( $titleObjs[$name] );
106106
107 - $images = array_merge( $images, $repo->findFiles( $titleObjs, $flags ) );
 107+ $images = array_merge( $images, $repo->findFiles( $titleObjs ) );
108108 }
109109 return $images;
110110 }

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r44525Remove parameter from FileRepo::findFiles(), it was fubar and nobody was usi...vyznev04:35, 13 December 2008

Status & tagging log