r44541 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r44540‎ | r44541 | r44542 >
Date:21:07, 13 December 2008
Author:mrzman
Status:ok
Tags:
Comment:
* (bug 16626) action=delete now correctly handles empty "reason" param
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/api/ApiDelete.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/api/ApiDelete.php
@@ -161,7 +161,8 @@
162162
163163 if( !FileDeleteForm::haveDeletableFile($file, $oldfile, $oldimage) )
164164 return array(array('nofile'));
165 -
 165+ if (is_null($reason)) # Log and RC don't like null reasons
 166+ $reason = '';
166167 $status = FileDeleteForm::doDelete( $title, $file, $oldimage, $reason, $suppress );
167168
168169 if( !$status->isGood() )
Index: trunk/phase3/RELEASE-NOTES
@@ -505,6 +505,7 @@
506506 * (bug 16541) Added block expiry timestamp to list=logevents output
507507 * (bug 16613) action=protect doesn't tell when &cascade was set but cascading
508508 protection wasn't allowed
 509+* (bug 16626) action=delete now correctly handles empty "reason" param
509510
510511 === Languages updated in 1.14 ===
511512

Status & tagging log