r44525 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r44524‎ | r44525 | r44526 >
Date:04:35, 13 December 2008
Author:vyznev
Status:ok (Comments)
Tags:
Comment:
Remove parameter from FileRepo::findFiles(), it was fubar and nobody was using it anyway. (What we really need is some way to pass timestamps to that function, which probably requires further rethinking of the interface.)
Modified paths:
  • /trunk/phase3/includes/filerepo/FileRepo.php (modified) (history)
  • /trunk/phase3/includes/filerepo/LocalRepo.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/filerepo/FileRepo.php
——@@ -133,10 +133,10 @@
134134 * @param array $titles, an array of titles
135135 * @param int $flags
136136 */
137 - function findFiles( $titles, $flags ) {
 137+ function findFiles( $titles ) {
138138 $result = array();
139139 foreach ( $titles as $index => $title ) {
140 - $file = $this->findFile( $title, $flags );
 140+ $file = $this->findFile( $title );
141141 if ( $file )
142142 $result[$file->getTitle()->getDBkey()] = $file;
143143 }
Index: trunk/phase3/includes/filerepo/LocalRepo.php
——@@ -164,8 +164,7 @@
165165 /*
166166 * Find many files using one query
167167 */
168 - function findFiles( $titles, $flags ) {
169 - // FIXME: Comply with $flags
 168+ function findFiles( $titles ) {
170169 // FIXME: Only accepts a $titles array where the keys are the sanitized
171170 // file names.
172171

Follow-up revisions

RevisionCommit summaryAuthorDate
r44557Followup to r44525: remove the broken $flags parameter from RepoGroup::findFi...vyznev03:43, 14 December 2008

Comments

#Comment by Ilmari Karonen (talk | contribs)   04:38, 13 December 2008

That should of course say "Remove $flags parameter ...", but the shell mangled my commit message. :(

Status & tagging log